Skip to content

Added extra Serial prints just before the TX&RX pins are disabled #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Added extra Serial prints just before the TX&RX pins are disabled #157

merged 1 commit into from
Apr 22, 2020

Conversation

PaulZC
Copy link
Contributor

@PaulZC PaulZC commented Apr 22, 2020

Third time lucky?! Or maybe it is fourth?!

@PaulZC
Copy link
Contributor Author

PaulZC commented Apr 22, 2020

The options are there when you submit the PR:

image

But disappear afterwards:

image

Cheers!

@oclyke
Copy link
Contributor

oclyke commented Apr 22, 2020

Ah - once again I am juggling too much and moving too fast. The outdated GIF I saw was pre-submission. I see. Anyway that worked great!

oclyke
oclyke approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@oclyke oclyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes still look good and PR targets release-candidate

@oclyke oclyke merged commit 269de5c into sparkfun:release-candidate Apr 22, 2020
@PaulZC
Copy link
Contributor Author

PaulZC commented Apr 23, 2020

Good man Owen - thank you,
All the best,
Paul

@PaulZC PaulZC deleted the PaulZC__LowPower_Example_Tweaks branch April 23, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oclyke oclyke oclyke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulZC @oclyke